Skip to content

Misc Python DSL Fixes#233

Open
KetanReddy wants to merge 8 commits intomainfrom
fix/python-dsl-classes
Open

Misc Python DSL Fixes#233
KetanReddy wants to merge 8 commits intomainfrom
fix/python-dsl-classes

Conversation

@KetanReddy
Copy link
Member

@KetanReddy KetanReddy commented Jan 8, 2026 •
edited by intuit-svc
Loading

A handful of fixes found during an internal round of DSL testing.

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Release Notes

  • DSL: Update all base Player constructs to extend Serializable
  • DSL: Remove None and empty objects values from object during serialization
  • DSL: Fix serialization of additional properties dictionaries on supported objects
  • Generation: Fix issue where assets passed as an array to another asset during init wouldn't go through the with method, preventing the proper parent from being associated with it
  • DSL: Prefer explicitly set ID over generated ID
📦 Published PR as canary version: 0.12.1--canary.233.5973

Try this version out locally by upgrading relevant packages to 0.12.1--canary.233.5973

@KetanReddy KetanReddy requested a review from a team as a code owner January 8, 2026 23:17
@KetanReddy KetanReddy added the patch Increment the patch version when merged label Jan 8, 2026
@KetanReddy
Copy link
Member Author

KetanReddy commented Jan 8, 2026

/canary

@codecov
Copy link

codecov bot commented Jan 8, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 84.07080% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.29%. Comparing base (129d3b8) to head (f6ab64d).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
language/generators/python/src/utils.py 21.42% 11 Missing ⚠️
language/dsl/python/src/view.py 58.33% 5 Missing ⚠️
language/dsl/python/src/navigation.py 96.49% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   64.28%   64.29%           
=======================================
  Files         128      128           
  Lines       13006    13032   +26     
  Branches     1867     1882   +15     
=======================================
+ Hits         8361     8379   +18     
- Misses       4617     4625    +8     
  Partials       28       28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KetanReddy
Copy link
Member Author

KetanReddy commented Jan 14, 2026

/canary

@KetanReddy KetanReddy changed the title Update all base Player constructs to extend Serializable Misc Python DSL Fixes Jan 14, 2026
@KetanReddy
Copy link
Member Author

KetanReddy commented Jan 14, 2026

/canary

@KetanReddy
Copy link
Member Author

KetanReddy commented Jan 15, 2026

/canary

@KetanReddy
Copy link
Member Author

KetanReddy commented Jan 27, 2026

/canary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

patch Increment the patch version when merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@KetanReddy